https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24190
Jonathan Druart <jonathan.dru...@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.dru...@bugs.koha-c | |ommunity.org --- Comment #14 from Jonathan Druart <jonathan.dru...@bugs.koha-community.org> --- Some comments: 1. You really should avoid indentation spaces outside of the block you are editing. It makes rebase a nightmare for you and for those who will have to rebase on top of it. 2. Why are you using the "%010d" format? Why are not you dumping (using Data::Dumper) the whole $budget? I have not tested but + sprintf("%010d", $del_adj->invoiceid) . + sprintf("%010d", $del_adj->budget_id) . That will produce a concat of 00000000010000000001 (for invoiceid=1 and budget_id=1 Is it really what we expect? And why 10? rrp_tax_excluded is decimal(28,6) for instance 3. + eval { output_pref({ dt => dt_from_string( $input->param('budget_period_startdate') ), dateformat => 'iso', dateonly => 1 } ); } . I don't think we should store formatted dates. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/