https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30055
--- Comment #35 from Jonathan Druart <jonathan.druart+k...@gmail.com> --- (In reply to Martin Renvoize from comment #29) > Hmm, right now I'm getting 404's on the API requests in my testing.. > continuing to investigate. > > Couple of comments to get us started though.. > > * It might be nice to enable `"header_filter": true,` on the kohaTable.. the > URL's are pretty crazy to read without it. Not strongly attached to that. Could switch to header_filter if your prefer. > * Was it a deliberate choice to use 'add_filters'.. for the guarantor search > at least, this is a change and I'm not sure it makes sense to have the both > sets of filters visible at the same time in the popup window? Yes, that's definitely a deliberate choice. The idea is to keep the same filters as before on top of the table, but provide a way to refine the search with the column's filters. I would like to have the same behaviour/UI on all patrons search. You also noticed the "Browse by last name" that will be there as well. (In reply to Martin Renvoize from comment #30) > Also, could we get a little update for the jsdoc for kohaTable for the > changes/enhancements you've made.. especially the signature update for > default_filters? Yep, I was waiting for the other bug follow-ups and feedbacks to make sure it's the correct way to accomplish that. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
