https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822
David Nind <da...@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement changes |This enhancement changes release notes|the |the |DefaultPatronSearchFields |DefaultPatronSearchFields |system preference from an |system preference from an |input field where field |input field where field |values separated by a comma |values separated by a comma |are entered, to a dropdown |are entered, to a modal |list with a limited subset |window listing all patron |of the available patron |fields (non-selectable |fields. |fields are greyed out). | | |This makes it much |This makes it much easier |easier to set the standard |to set the standard fields |fields for patron search, |for patron search, and |and helps avoid breaking |helps avoid breaking the |the patron search when |patron search when |incorrect field values are |incorrect field values are |entered. |entered. | | |NOTE: There is a | |change in behavour for this | |system preference, as only | |a limited subset of the | |available patron fields are | |now selectable for the | |standard patron search. | --- Comment #53 from David Nind <da...@davidnind.com> --- Testing notes using KTD: 1. Check system preference DefaultPatronSearchFields and note that it is defined by entering a comma separated list. 2. Go to the patrons module and view the HTML source for the page: . search the source for 'standard' - this should have two results . note that the option value for the Standard input field are "firstname,middle_name,surname,othernames,cardnumber,userid" 3. Break the patron search: . for the DefaultPatronSearchFields system preference, add a field that doesn't exist, for example: someunknownfield . for patron search, enter any value in the search field and make sure standard is selected for the search field drop down list . you get a pop-up error message: "Something went wrong when loading the table. 500: Internal Server Error." 4. Apply the patch. 5. Update the database: databaseupdate 6. Restart everything: flushmemcached, restart_all 7. Reload or search again for the DefaultPatronSearchFields system preference. 8. Note that this is now a modal window with all the patron fields that are selectable shown (greyed out items are not selectable), rather than needing to enter a comma separated list. 9. Select some fields, such as 'First name', 'Surname', 'Primary email'. 10. Repeat step 2 - the standard input field now includes the fields you selected. 11. Make sure some patrons have a primary email address, such as firstn...@gmail.com 12. Do a standard search for gmail.com ==> the results should include all the patrons you added a gmail address to 13. Do a specific search on the 'Primary email' field ==> the search results should be the same as for step 12 14. Run the tests, these should pass (note - KTD needs to be started with selenium: ktd --selenium up): . prove t/db_dependent/selenium/patrons_search.t BONUS: Perform the same search using the header search bar and the search options drop down (note: you need to change the 'Search type' from 'Starts with' to 'Contains'). -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/