https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34694
Emily Lamancusa <emily.lamanc...@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa@montgomeryc | |ountymd.gov --- Comment #6 from Emily Lamancusa <emily.lamanc...@montgomerycountymd.gov> --- (In reply to Fridolin Somers from comment #5) > Ah, Bug 30846 also impacted opac/opac-ISBDdetail.pl and > opac/opac-MARCdetail.pl > > And isn't is better to use 'and' instead of '&&' ? > https://perldoc.perl.org/perlop#Logical-And > > Also even if not mandatory in my opinion we should add parenthesis to > explain the logic. I think the parentheses WOULD be mandatory if it was switched to 'and', because 'and' has lower precedence than '||'. https://perldoc.perl.org/perlop#Operator-Precedence-and-Associativity Can you explain more about why 'and' would be better in this case? At first I was thinking it was because we want it to short-circuit if $patron is not defined, but looking at the section for '&&', '&&' will also short-circuit, so I'm not clear on what the advantage of 'and' would be. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/