https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34764
Kyle M Hall <k...@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155578|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall <k...@bywatersolutions.com> --- Created attachment 155597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155597&action=edit Bug 34764: Set fee_acknowledged to expect a string For consistency with other options I opted to have the fee acknowledged parameter to expect a string and as it's an optional parameter I've dropped the default value of 'N' too. Test plan 1) Prior to this patch 1a) Attempt a checkout without passing -fa/--fee_acknowledged flag `./misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL --patron 23529000035676 --item 39999000007756 -m checkout` The final field of the SIP request will be '|BON', the default 1b) Attempt a checkout passing -fa/--fee_acknowledged flag `./misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL --fee-acknowledged --patron 23529000035676 --item 39999000007756 -m checkout` The final field of the SIP request will still be '|BON', failure 1c) Attempt a checkout passing a string for fee_acknoewledeged flag `./misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL --fee-acknowledged Y --patron 23529000035676 --item 39999000007756 -m checkout` The final field of the SIP request will still be '|BON', failure 2) Apply the patch 2a) Attempt a checkout without passing -fa/--fee_acknowledged flag `./misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL --patron 23529000035676 --item 39999000007756 -m checkout` The optional `|BO` element should not be present 2b) Attempt a checkout passing -fa/--fee_acknowledged flag `./misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL --fee-acknowledged N --patron 23529000035676 --item 39999000007756 -m checkout` The final field of the SIP request will now be '|BON', success 2c) Attempt a checkout passing a string for fee_acknoewledeged flag `./misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 -l CPL --fee-acknowledged Y --patron 23529000035676 --item 39999000007756 -m checkout` The final field of the SIP request will now be '|BOY', success Signed-off-by: David Nind <da...@davidnind.com> Signed-off-by: Kyle M Hall <k...@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/