https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36420
Kyle M Hall <k...@bywatersolutions.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #163984|0 |1
is obsolete| |
Attachment #163985|0 |1
is obsolete| |
--- Comment #3 from Kyle M Hall <k...@bywatersolutions.com> ---
Created attachment 163991
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163991&action=edit
Bug 36420: Allow Basic authentication using `cardnumber`
This patch makes the API Basic authentication work with cardnumbers.
The used `checkpw_internal` method already does the fallback check.
To test:
1. Apply the unit tests patch
2. Run:
$ ktd --shell
k$ prove t/db_dependent/api/v1/auth_basic.t
=> FAIL: Tests explode! [1]
3. Apply this patch
4. Repeat 2
=> SUCCESS: Tests pass!
5. Sign off :-D
[1] This highlights an underlying bug! Instead of getting 403, etc we get a
500. This is because of the internal fallback mechanism allowing the
cardnumber+password combination, but then the Koha::Patron->find... not finding
:-D
Signed-off-by: Tomas Cohen Arazi <tomasco...@theke.io>
Signed-off-by: Kyle M Hall <k...@bywatersolutions.com>
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
