https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20644
Nick Clemens <n...@bywatersolutions.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |n...@bywatersolutions.com
Status|Signed Off |Failed QA
--- Comment #6 from Nick Clemens <n...@bywatersolutions.com> ---
Must fix:
In wants_check_for_previous_checkout we should pass the item _object rather
than unblessed. This would let us use the effective_itemtype routine to get the
itemtype (in the case where Record Level itemtypes might be in use)
The schema changes should be in their own patch to allow the RM to regenerate
In the tests it says new types are generated as NULL but it should say
'inherit'
QA tool complains about tidiness
Should fix:
Why does the item type choice say :try and override"? Looks like the item type
setting trumps all except hard syspref, and it won't display if hard syspref
set?
Could fix:
You can use testbuilder to generate the types for testing, there is no need to
specify item type code, just check against what is generated.
Would fix:
Test could be a bit more verbose to be readable, the map is not as clear as a
straightforward loop would be, but I like the laid out matrix explaining the
results
The update could test for existence of column and not run when exists, but the
construction you use does work.
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
