https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20644
--- Comment #12 from Matthias Le Gac <matthias.le-...@inlibro.com> ---
I changed "item_unblessed" to "item_object".
Put the shema changes in a different patch.
Adjusted the tidiness.
But for the point where in the tests it's marked NULL and not "inherit" I don't
know what you're talking about, because for me it's already marked "inherit" as
requested.
For the "should fix" point, could you be more precise? I don't know which part
you're talking about.
The same goes for the "would fix" part. Could you be more specific about how to
improve test comprehension?
For the "could fix" part, I've tried to change using the builder, but with the
builder you can't create an "ItemType" with the value "checkprevcheckout" at
"undef" because this field can't be empty, so the builder throws an error.
I tried this:
my $itemType1 = $builder->build_object({
class => 'Koha::ItemTypes',
value => {
checkprevcheckout => undef,
}
});
and I get this error:
"Null value for checkprevcheckout in Itemtype not allowed at
/inlibro/git/koha-master-dev-matthias/t/lib/TestBuilder.pm line 430."
Tell me if there is another solution with the builder or if we leave it as it
is now?
Finally, for the last point about the script that adds the column, there's
already something that tests whether the column exists, isn't there? with :
"ALTER TABLE itemtypes ADD IF NOT EXISTS checkprevcheckout"
Does "ADD IF NOT EXISTS" do this?
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
