https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35659
Victor Grousset/tuxayo <vic...@tuxayo.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Failed QA
--- Comment #78 from Victor Grousset/tuxayo <vic...@tuxayo.net> ---
Unused import:
use C4::Log qw( cronlogaction );
in
Koha/OAI/Client/Harvester.pm
---
To doublecheck that it was really unused and there wasn't some weird perl
feature at play, I removed it and ran the tests. But that might not be reliable
if coverage isn't good enough.
So I removed this which was used in multiple places:
use C4::AuthoritiesMarc qw (AddAuthority GuessAuthTypeCode ModAuthority
DelAuthority );
And the tests still passed! 😱
Now checking coverage more seriously with Devel::Cover
https://wiki.koha-community.org/wiki/Coding_Guidelines#PERL17:_Unit_tests_are_required
from ./cover_db/coverage.html
file stmt bran cond sub total
Koha/OAI/Client/Harvester.pm 55.6 38.1 66.6 88.8 57.1
That's certainly too low :(
The file is clickable to have a very nice view of it's code and colors to see
which are the lines covered or not. And it can give details on which values for
conditions aren't covered.
And all the stuff from C4::AuthoritiesMarc was used in these uncovered parts.
Looking at the per files reports showed that these files seem not used in tests
vs the biblio one that are:
Koha/Import/OAI/Authority.pm
Koha/Import/OAI/Authorities.pm
Despite their decent scores coming from the imports statements ^^"
----
Found very minor style issues:
#use searchfield only in remaining operations
[...]
#find server(s) by id or name
(need a space after #)
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
