https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35287
--- Comment #73 from Victor Grousset/tuxayo <[email protected]> --- Thanks Paul for the rest of the QA :D From my code review in august, everything looked compliant with the coding guidelines ☑️ Except for JS8 (ESLint compliance) for which the tooling isn't working to effectively look at it. ¯\_ (ツ)_/¯ ----- Still, reliably catching stuff like unused variables, unreachable code and other things hard to manually look for would be nice. After fighting tooth and nail with node packaging and ESLint config, I got something running to experiment here and help with the almost 1000 lines of .vue .ts. And the result is that the changes look pretty good 👍 Config needs for tuning to our practices so there is a lot of noise that I'm filtering plus now I don't bother with minor stuff like using const on every not reassigned variable and order of attributes in Vue markup. Here are some quick suspicious things that remain: t/cypress/integration/AdditionalFields_spec.ts 2:15 error A `require()` style import is forbidden @typescript-eslint/no-require-imports Is that really bad? (For this ticket at least. Knowing if this rule should be disabled is for another day ^^, unless it's obvious if it's relevant for the future or not) koha-tmpl/intranet-tmpl/prog/js/vue/components/AdditionalFieldsEntry.vue 16:21 error Elements in iteration expect to have 'v-bind:key' directives vue/require-v-for-key 50:21 error Elements in iteration expect to have 'v-bind:key' directives vue/require-v-for-key 65:29 warning Attribute "v-model" should go before ":multiple" vue/attributes-order 83:21 error Elements in iteration expect to have 'v-bind:key' directives vue/require-v-for-key 83:21 error Elements in iteration expect to have 'v-bind:key' directives vue/require-v-for-key Is that really bad? ----- I think that's all, so good news :) -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
