https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391
--- Comment #92 from Pedro Amorim <[email protected]> --- Hey looking here, some minor observations (these may not be issues and are possibly caused by my lack of understanding - follow-up as you see fit): In koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt We have IF Koha.Preference('UseRecalls') != "off" Should it not be IF Koha.Preference('UseRecalls').match('opac) i.e. do we want to show this on this template if UseRecalls = 'staff'? In opac-recall.pl: Shouldn't the check for if($op eq 'cud-cancel) be inside the if ( C4::Context->preference('UseRecalls') =~ m/opac/ ) check? --------- Code looks good and QA script is happy. I'll follow the test plan soon and provide a SO if all is well. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
