https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38664
--- Comment #18 from Julian Maurice <[email protected]> --- > @all Is there anything important that should be changed in the .perltidyrc > and .prettierrc.js ? > It's now or never I don't think that tidying the whole codebase now prevents us to change the rules later (we'll just have another "tidy all" commit at the same time, which will probably be much smaller, depending on the rules changed). Anyway if we're considering changing the .perltidyrc I would advocate for adding -novalign (disabling vertical alignment). Vertical alignment may have some benefits, but it often requires changing code unrelated to the patch, making the patch bigger and harder to read. And when you have one long key/variable name it moves other values away from their key/variable name, making the code harder to read. I also dislike how spaces are added everywhere between parenthesis, but it's a minor inconvenience. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
