https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137

Brendan Lawlor <blaw...@clamsnet.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #132 from Brendan Lawlor <blaw...@clamsnet.org> ---
Thanks for working on this Thibaud! A global checkout limit is important for
our consortium.

I am happy to test this again when this error is resolved.

The patch applies, but after running updatedatabase and dbic I get an error
when running restart_all:

Starting Z39.50/SRU daemon for kohadev:"my" variable $self masks earlier
declaration in same scope at /kohadevbox/koha/Koha/CirculationRules.pm line
324.
"my" variable $params masks earlier declaration in same scope at
/kohadevbox/koha/Koha/CirculationRules.pm line 324.
"state" variable @_ masks earlier declaration in same scope at
/kohadevbox/koha/Koha/CirculationRules.pm line 324.

Also the QA script complains on a few things:

 FAIL   Koha/CirculationRules.pm
   FAIL   pod coverage
                POD coverage was greater before, try perl
-MPod::Coverage=PackageName -e666
   FAIL   valid
                "my" variable $self masks earlier declaration in same scope
                "my" variable $params masks earlier declaration in same scope
                "state" variable @_ masks earlier declaration in same scope
                "my" variable $rule_name masks earlier declaration in same
scope
                "my" variable $categorycode masks earlier declaration in same
scope
                "my" variable $itemtype masks earlier declaration in same scope
                "my" variable $branchcode masks earlier declaration in same
scope
                "my" variable $rule masks earlier declaration in same scope
                "my" variable $self masks earlier declaration in same scope
                "my" variable $params masks earlier declaration in same scope
                "state" variable @_ masks earlier declaration in same scope
                "my" variable $categorycode masks earlier declaration in same
scope
                "my" variable $itemtype masks earlier declaration in same scope
                "my" variable $branchcode masks earlier declaration in same
scope
                "my" variable $has_priority masks earlier declaration in same
scope
                "my" variable $self masks earlier declaration in same scope
                "my" variable $params masks earlier declaration in same scope
                "state" variable @_ masks earlier declaration in same scope
                "my" variable $branchcode masks earlier declaration in same
scope
                "my" variable $categorycode masks earlier declaration in same
scope
                "my" variable $itemtype masks earlier declaration in same scope
                "my" variable $rule_name masks earlier declaration in same
scope
                "my" variable $has_priority masks earlier declaration in same
scope
                "my" variable $rule masks earlier declaration in same scope
                "my" variable $memory_cache masks earlier declaration in same
scope
                syntax error
                Can't use global @_ in "my"
                Global symbol "$params" requires explicit package name (did you
forget to declare "my $params"?)
                syntax error
                Can't use global @_ in "my"
                syntax error
                Can't use global @_ in "my"
                syntax error
                Can't use global @_ in "my"
                syntax error
                /kohadevbox/koha/Koha/CirculationRules.pm has too many errors.
                Compilation failed in require

 WARN   Koha/Schema/Result/CirculationRule.pm
   WARN   tidiness
                The file is less tidy than before (bad/messy lines before: 41,
now: 43)

 FAIL   Koha/Template/Plugin/CirculationRules.pm
   FAIL   pod coverage
                POD coverage was greater before, try perl
-MPod::Coverage=PackageName -e666
   FAIL   valid
                "my" variable $self masks earlier declaration in same scope
                "my" variable $params masks earlier declaration in same scope
                ...

 FAIL   admin/smart-rules.pl
   WARN   tidiness
                The file is less tidy than before (bad/messy lines before: 137,
now: 154)
   FAIL   valid
                "my" variable $self masks earlier declaration in same scope
                "my" variable $params masks earlier declaration in same scope
                "state" variable @_ masks earlier declaration in same scope
                ...

 FAIL   installer/data/mysql/atomicupdate/Bug_8137-add-column-has_priority.pl
   FAIL   file permissions
                File must have the exec flag

 FAIL   installer/data/mysql/kohastructure.sql
   FAIL   tinyint_has_boolean_flag
                The new column circulation_rules.has_priority is using
TINYINT(1) as type but is not defined as boolean in the schema file
(Koha/Schema/Result/CirculationRule.pm), see the SQL12 coding guideline

 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt
   FAIL   forbidden patterns
                forbidden pattern: tab char (line 1835)
                forbidden pattern: tab char (line 1837)
   FAIL   spelling
                 librairies ==> libraries
                 librairies ==> libraries

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to