https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38842
Bug ID: 38842
Summary: Refactor modal logic in returns.tt / returns.pl
Change sponsored?: ---
Product: Koha
Version: Main
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Templates
Assignee: [email protected]
Reporter: [email protected]
QA Contact: [email protected]
Depends on: 38588, 38789, 38793
The logic for displaying modals on the checkin page is badly in need of
refactoring. There are 10 separate modals coded in returns.tt, plus an
additional 2 modal include files. There is also at least one parameter (found)
that is duplicated for completely different meanings in different contexts, and
several other similar-sounding parameters in different contexts whose meaning
is no longer clear without code tracing how the value was assigned.
All of this leads to a lot of code duplication and error-prone code, and makes
it very confusing to follow the template/controller logic when developing or
debugging. We should refactor down to one modal with clear logic for filling in
its contents.
See also comments on bug 38588
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38588
[Bug 38588] Checkin that triggers a transfer => print slip => Internal server
error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38789
[Bug 38789] Wrong Transfer modal does not show
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38793
[Bug 38793] Transfer silently not canceled when TransfersBlockCirc = "don't
block" and AutomaticConfirmTransfer = "do automatically confirm"
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
