https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38713

Lucas Gass (lukeg) <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]

--- Comment #7 from Lucas Gass (lukeg) <[email protected]> ---
I have reviewed each of the changed files: 


We should certainly fix this here: 

reserve/request.tt:
<i class="fa fa-exclamation-triangle fa-lg" style="color:gold" title="Requires
override of hold policy" />
<i> tags should not be self-closing. 


Things I am noting that we can fix here, or open separate bugs for: 

modules/opac-reset-password.tt:
I know the others in the SWITCH/CASE are <span> but <span></span><br /> is
better as just <div></div>
<span>Please log-in to account to update your password.</span><br /> 

should be: <div>Please log-in to account to update your password.</div> 

serials/subscription-add.tt
<center> tag is unsupported in HTML, should be CSS instead.

catalogue/results.tt
<br/>OR<br/> is weird. Should be <p>OR</p> and it’s parent probably needs to be
a <div>

includes/member-display-alt-address-style.inc
Best to avoid <br/> for splitting up the content. Wrapping in <p> tags would be
better, IMO.

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to