https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38713
--- Comment #8 from Jonathan Druart <[email protected]> --- (In reply to Lucas Gass (lukeg) from comment #7) > I have reviewed each of the changed files: > > > We should certainly fix this here: > > reserve/request.tt: > <i class="fa fa-exclamation-triangle fa-lg" style="color:gold" > title="Requires override of hold policy" /> > <i> tags should not be self-closing. Indeed, fixed in "Bug 38713: i tags should not be self-closing" It's the only occurrence I found. Command used: perl -0777 -ne 'print "Self-closing <i> tag found in $ARGV: $1\n" while /(<i(?:\s+[^>]*)?\/>)/ig' **/*.tt **/*.inc > Things I am noting that we can fix here, or open separate bugs for: > > modules/opac-reset-password.tt: > I know the others in the SWITCH/CASE are <span> but <span></span><br /> is > better as just <div></div> > <span>Please log-in to account to update your password.</span><br /> > > should be: <div>Please log-in to account to update your password.</div> Yes, that's for somewhere else as the change made here are only replacing </br> to the correct <br/> > serials/subscription-add.tt > <center> tag is unsupported in HTML, should be CSS instead. Done in "Bug 38713: Replace <center> by its css equivalent" There is another occurrence that is going to be removed on bug 38952. > catalogue/results.tt > <br/>OR<br/> is weird. Should be <p>OR</p> and it’s parent probably needs to > be a <div> I agree, but there is a tiny UI change when switching to p. Better to deal with this separately that making a change that will be hidden in this big set. > includes/member-display-alt-address-style.inc > Best to avoid <br/> for splitting up the content. Wrapping in <p> tags would > be better, IMO. Same that previously, br is the current tag, I prefer to deal with that separately. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
