https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24401

--- Comment #34 from Tomás Cohen Arazi (tcohen) <[email protected]> ---
(In reply to Jan Kissig from comment #33)
> 
> The actual checkout is now POST /api/v1/checkouts with a body { patron_id,
> external_id }
> Analog to this the checkin would be DELETE /api/v1/checkouts but DELETE does
> not allow a request body so I used POST /api/v1/checkin instead. I know this
> is ugly and the above routes from the wiki would make more sense.

I tend to agree with doing the `POST /checkins` but I feel the proposal should
be added to the wiki [here](https://wiki.koha-community.org/wiki/REST_api_RFCs)
and announce it so others express their thoughts too.

My main doubt to be honest, is that we have talked a lot over the last years
about merging the `issues` and `old_issues` tables, and considering that, we
might want to give this more thought.

As we will always perform the checkin (thinking of the UI) starting from a
barcode, my personal preference is we do

```
POST /checkins
{"external_id":"123456"}
```

and get the `Location` header containing a reference to the checkout object.
But I really need some time to ponder as well as others.

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to