https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36350
Julian Maurice <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #35 from Julian Maurice <[email protected]> --- (In reply to David Gustafsson from comment #34) > I am aware of this, and though the cache option in DBix is very poorly > documented I think it's actually necessary [...] This part worries me. Using an obscure option because we /think/ it's necessary does not sound like a good idea. We need to be sure that it's necessary and we need know exactly what this option does. But even with that put aside, I'm skeptical about the implementation, in particular the fact that the cache is managed at the Koha::Object(s) level. If I read the flame graphs correctly, the bad performance was due to Koha::Number::Format::Price::_format_params repeatedly fetching the active currency. Why not put the cache there ? It would be a lot simpler and safer, and would allow for the same magnitude of performance boost. The patch also touches libraries, patrons, ILL requests and item types but there is no evidence given that it does improve performance. Can you provide some ? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
