https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010
--- Comment #269 from Matt Blenkinsop <[email protected]> --- (In reply to Jonathan Druart from comment #194) > Had a quick look at the UI, some notes: > 1. "Save" => "Submit" > 2. No more sticky toolbar > 3. > a. "Add vendor" => "New vendor" > b. It's not h2 instead of h1 > 4. Alias > a. can be added empty (was not possible before) > b. "Remove" does not remove the correct alias > 5. http://localhost:8081/cgi-bin/koha/acqui/booksellers.pl?booksellerid=2 > "Edit" is http://localhost:8081/cgi-bin/koha/vendors/2 ("show" view) > 6. Empty contact can be added (was not possible before) > 7. "Delete contact" and "Remove this interface" is not consistent (in > wording, in position, and in styling) > 8. Discount and delivery time have type="number" > https://wiki.koha-community.org/wiki/Coding_Guidelines#ACC2:_Input_type_. > 22number.22_should_be_avoided > 9. Delete not working > http://localhost:8081/cgi-bin/koha/acqui/booksellers.pl?booksellerid=2 > "Delete vendor", yes > => 404 and vendor is not deleted. > 10. Breadcrumb > a. Small glitch in the breadcrumb (spacing difference before 'Vendors'?) > https://snipboard.io/GQ5XRs.jpg > vs > https://snipboard.io/fubCc5.jpg > b. http://localhost:8081/cgi-bin/koha/vendors > 'Vendors' is a link (http://localhost:8081/cgi-bin/koha/vendors#) > 11. Interfaces > a. On the "show" view, "Type" is displayed when not filled (was not before) > b. The name of the interface is now in a `legend` tag, was h3 before. I > don't think you can use `legend` for something else than `fieldset`. > 12. We are missing tests. You should have a look at bug 38461 and bug 38503. I've addressed all of the above as best I can, the only one I'm not sure on is point 12 - what specifically do you want to see tests for? The main functions are CRUD which there are cypress tests for. I've also added more unit tests for the .pm methods -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
