https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010
--- Comment #270 from Matt Blenkinsop <[email protected]> --- (In reply to Jonathan Druart from comment #195) > 13. The vendor search result is really different from what we have > currently, and it's missing a lot of info and actions (basket list, "add to > basket", "show all baskets", "show active vendors only", the ability to > basket or contract for a vendor). Has this been discussed before already? There were issues for libraries with large numbers of vendors and baskets - the vendor search could take a long time to load so the plan was to use the migration to make use of the new datatables work to allow pagination and search. The table filters allow for easy searching and filtering, with much faster load time (In reply to Jonathan Druart from comment #196) > The permissions store is a bit weird as you rely on a global JS variable. > How could this be reusable from the ERM module for instance? > > It would really have been great to have such concepts/ideas isolated into > their own bug instead of lost in this huge set... I've moved this to bug 38930 (In reply to Jonathan Druart from comment #198) > + `${(vendor.tax_rate * 100).toFixed(2)}` + "{enter}", > > + label: `${(gv.option * 100).toFixed(2)}%`, > > I don't think this is correct, you should use format_price (from > format_price.inc) Done (In reply to Jonathan Druart from comment #202) > Code duplication, the acquisition menu is now in > koha-tmpl/intranet-tmpl/prog/en/includes/acquisitions-menu.inc and > koha-tmpl/intranet-tmpl/prog/js/vue/components/Islands/AcquisitionsMenu.vue > This should be on its own bug really. Replace the left menu everywhere > before this and don't duplicate the code. Bug 38941 (In reply to Jonathan Druart from comment #200) > What's the purpose of VendorDetails.vue? I don't see how it could be useful. The vendor form component was so long and bloated, same with VendorShow. I wanted to make it more readable by splitting the html out into separate components (In reply to Jonathan Druart from comment #204) > Koha/Acquisition/Bookseller.pm > + $interface->password( $interface->plain_text_password ); > > Do we really want to expose the password? Maybe not something for now, but > we should maybe have the "****" trick here with a "show" that will trigger a > special route for plain text password (just for discussion as I am reading > this code) This was discussed on Mattermost and we agreed this was the best way forward for now. The documentation has been updated to make it clear that Koha is not a password manager and that passwords will be visible through the API -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
