https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551
--- Comment #110 from David Gustafsson <[email protected]> --- (In reply to Fridolin Somers from comment #107) > Arg I've been using this feature on an a big export and DB server crashed. > I see the output file is not filled little by little. > > I think it comes from this change : > > + @records = map { > + my $record = _get_record_for_export( { %{$params}, record_id => > $_ } ); > + $record ? $record : (); > + } @{$record_ids}; > > For a huge export the @records object will take too much RAM. > > Without this path the records are build one by one. > > Please make some tests to confirm. Good catch, didn't think about that aspect, I fixed this by using an iterator instead. I don't think we need to think about the performance cost of running GetMarcFromKohaField multiple times as it's only called for records with encoding errors, which should be a very small proportion of the total records. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
