https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38357
--- Comment #17 from Tomás Cohen Arazi (tcohen) <[email protected]> --- (In reply to Jonathan Druart from comment #15) > (In reply to Tomás Cohen Arazi (tcohen) from comment #13) > > Is there a reason not to get rid of all the `our` variable definitions? I'm > > not sure we know exactly why it is being used. > > > > We only know those variables persist in memory in Plack mode (and other > > persistent runtime environments). > > It has a global scope, and is available from the subroutines. > When switching to plack we (lazily) switched some "my" to "our" to just make > things worked. > > It can be fixed, but it's not simply a s/^our/my/g substitution. > > But yes, it must be done. Yeah, I know. I asked on Mattermost too, if someone remembered some caching mechanism would need to be re-done (i.e. if this was somehow a feature). I think we all agree this needs to go away. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
