https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

--- Comment #62 from Martin Renvoize (ashimema) 
<[email protected]> ---
Comment on attachment 181340
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181340
Bug 9762: Log circulation overrides

Review of attachment 181340:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=9762&attachment=181340)
-----------------------------------------------------------------

::: C4/Circulation.pm
@@ +832,4 @@
>      my $circ_library = Koha::Libraries->find( _GetCircControlBranch( 
> $item_object, $patron ) );
>  
>      my $now = dt_from_string();
> +    my $message;

I don't see `$message` passed anywhere.. we seem to construct what could be a
huge concatenated string below, but then never output it anywhere.

We also have this on line 1822:

  `my ( $allowed, $message ) = CanBookBeReturned( $item_unblessed,
C4::Context->userenv->{branch} );`

This will overwrite whatever was in $message above.. and it's intended to just
be a branchcode passed back in that case.

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to