https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23010
--- Comment #35 from Emily Lamancusa (emlam) <[email protected]> --- (In reply to Lucas Gass (lukeg) from comment #33) > > I do have one question, though: in Item.pm, the store method is throwing an > > exception in the middle if a withdrawn status is blocked by the syspref. > > Wouldn't that interrupt the processing of unrelated fields? (Or am I missing > > some Perl magic here?) > > Good question, Emily! I wrote this so if you try to update an item to a > status that is not allowed via the system preference, we stop and exit. You > can't get into this IF statement unless the syspref is on and you are > editing the withdrawn status. If you edit other fields they won't be saved. > > It sounds like you would like this warn the user that they cannot updated > the withdrawn status but continue to update other fields they have changes > at that same time? Thanks for clarifying the intent here, Lucas! I was partly thinking about whether other fields should still be updated, and partly concerned about whether there would be side effects from the code that runs before we stop and exit. Both of these concerns mostly came from me missing/forgetting how Koha Objects and DBIC work, so please disregard my previous comment. :) I will try to QA this next week, but I'm not confident I'll be able to get to it before the soft feature freeze, so not setting myself as the QA contact just yet. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
