https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23010
--- Comment #42 from Lucas Gass (lukeg) <[email protected]> --- > == Needs feedback == > > From additem.pl (around line 650): > > + } catch { > + if ( ref $_ && $_->can('error') ) { > + push @errors, $_->error; > + } > + } > > Should we do something else with the error (or die/rethrow) if not > $_->can('error')? I imagine it would be a pretty unusual edge case for that > check to fail, but if it does, we shouldn't fail silently. OK, looking back here I am unclear why I did this. I don't think we need to do the `if ( ref $_ && $_->can('error') ) {` We should just try to store and if not catch the error -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
