https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37364
Lin Wei <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] Status|Needs Signoff |Failed QA --- Comment #12 from Lin Wei <[email protected]> --- # Personal Note First of all, I'd like to say I'm sorry that your work was ignored for so long. That's definitely not fun. I am new to this, but I still tried to take a look at it. To be honest, I am not at all familiar with the MARC format, so it's hard for me to sign off on the feature, but I did run your unit tests and I've provided the results below. If I may, I have one small piece of advice that might help: I recommend you provide a clear test plan. Otherwise, it's difficult to know how to test the patch/what needs to be tested, which usually limits potential testers to either people who are already involved in the patch or people who have the time and expertise to read and understand the entire discussion. # Test Results Unit tests do not pass. # Test Execution 1. Apply patch 2. Run `prove ./t/db_dependent/Koha/Biblio.t`. 3. Test fails. See [Prove Output] below. 4. Remove patch with `git reset --hard origin/main`. 5. Run `prove ./t/db_dependent/Koha/Biblio.t`. 6. All tests pass. # Prove Output prove ./t/db_dependent/Koha/Biblio.t ./t/db_dependent/Koha/Biblio.t .. 39/41 # Failed test 'no warnings' # at /usr/local/share/perl/5.38.2/Test/Builder.pm line 187. # There were 4 warning(s) # Previous test 0 '' # Argument " " isn't numeric in numeric eq (==) at /inlibro/git/koha-master-dev-linwei/Koha/Biblio.pm line 1960. # at /inlibro/git/koha-master-dev-linwei/Koha/Biblio.pm line 1960. # Koha::Biblio::generate_marc_host_field(Koha::Biblio=HASH(0x60810b9c8cc8)) called at ./t/db_dependent/Koha/Biblio.t line 1022 # main::__ANON__() called at /usr/local/share/perl/5.38.2/Test/Builder.pm line 368 # eval {...} called at /usr/local/share/perl/5.38.2/Test/Builder.pm line 368 # Test::Builder::subtest(Test::Builder=HASH(0x60810057c040), "generate_marc_host_field", CODE(0x6081003df578)) called at /usr/local/share/perl/5.38.2/Test/More.pm line 831 # Test::More::subtest("generate_marc_host_field", CODE(0x6081003df578)) called at ./t/db_dependent/Koha/Biblio.t line 1099 # # ---------- # Previous test 10 'MARC::Field->subfield(w) returns undef when "UseControlNumber" is disabled' # Argument " " isn't numeric in numeric eq (==) at /inlibro/git/koha-master-dev-linwei/Koha/Biblio.pm line 1960. # at /inlibro/git/koha-master-dev-linwei/Koha/Biblio.pm line 1960. # Koha::Biblio::generate_marc_host_field(Koha::Biblio=HASH(0x60810b9c8cc8)) called at ./t/db_dependent/Koha/Biblio.t line 1036 # main::__ANON__() called at /usr/local/share/perl/5.38.2/Test/Builder.pm line 368 # eval {...} called at /usr/local/share/perl/5.38.2/Test/Builder.pm line 368 # Test::Builder::subtest(Test::Builder=HASH(0x60810057c040), "generate_marc_host_field", CODE(0x6081003df578)) called at /usr/local/share/perl/5.38.2/Test/More.pm line 831 # Test::More::subtest("generate_marc_host_field", CODE(0x6081003df578)) called at ./t/db_dependent/Koha/Biblio.t line 1099 # # ---------- # Previous test 11 'MARC::Field->subfield(w) returns content from 003 and 001 when "UseControlNumber" is enabled' # Argument " " isn't numeric in numeric eq (==) at /inlibro/git/koha-master-dev-linwei/Koha/Biblio.pm line 1960. # at /inlibro/git/koha-master-dev-linwei/Koha/Biblio.pm line 1960. # Koha::Biblio::generate_marc_host_field(Koha::Biblio=HASH(0x60810b95d570)) called at ./t/db_dependent/Koha/Biblio.t line 1048 # main::__ANON__() called at /usr/local/share/perl/5.38.2/Test/Builder.pm line 368 # eval {...} called at /usr/local/share/perl/5.38.2/Test/Builder.pm line 368 # Test::Builder::subtest(Test::Builder=HASH(0x60810057c040), "generate_marc_host_field", CODE(0x6081003df578)) called at /usr/local/share/perl/5.38.2/Test/More.pm line 831 # Test::More::subtest("generate_marc_host_field", CODE(0x6081003df578)) called at ./t/db_dependent/Koha/Biblio.t line 1099 # # ---------- # Previous test 12 'MARC::Field->subfield(d) returns content from 264 in prefernce to 260' # Argument " " isn't numeric in numeric eq (==) at /inlibro/git/koha-master-dev-linwei/Koha/Biblio.pm line 1960. # at /inlibro/git/koha-master-dev-linwei/Koha/Biblio.pm line 1960. # Koha::Biblio::generate_marc_host_field(Koha::Biblio=HASH(0x60810ba88e68)) called at ./t/db_dependent/Koha/Biblio.t line 1060 # main::__ANON__() called at /usr/local/share/perl/5.38.2/Test/Builder.pm line 368 # eval {...} called at /usr/local/share/perl/5.38.2/Test/Builder.pm line 368 # Test::Builder::subtest(Test::Builder=HASH(0x60810057c040), "generate_marc_host_field", CODE(0x6081003df578)) called at /usr/local/share/perl/5.38.2/Test/More.pm line 831 # Test::More::subtest("generate_marc_host_field", CODE(0x6081003df578)) called at ./t/db_dependent/Koha/Biblio.t line 1099 # # Looks like you failed 1 test of 41. ./t/db_dependent/Koha/Biblio.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/41 subtests Test Summary Report ------------------- ./t/db_dependent/Koha/Biblio.t (Wstat: 256 (exited 1) Tests: 41 Failed: 1) Failed test: 41 Non-zero exit status: 1 Files=1, Tests=41, 17 wallclock secs ( 0.03 usr 0.01 sys + 11.19 cusr 1.87 csys = 13.10 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
