https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37364
--- Comment #16 from Lin Wei <[email protected]> --- No worries, glad I could help :) # Test Results - Unit tests pass. - Test plan was executed successfully. -> Technically, there is an issue with adding records created via Fast Cataloging to a Bundle/Collection. -> But, Fast Cataloging should not be used, so I am not going to disregard this issue. -> See below for details. # Test Execution 1. Apply 182393. 2. Run `prove ./t/db_dependent/Koha/Biblio.t`. 3. Tests fails (see [Prove Output] below). -> I realize this is normal as the tests are fixed in the following commit. 4. Reset with `git reset --hard origin/main`. 5. Run `prove ./t/db_dependent/Koha/Biblio.t`. 6. Tests pass. 7. Apply both 182393 and 182394. 8. Run `prove ./t/db_dependent/Koha/Biblio.t`. 9. Tests pass. -> Here is where I realize it. 10. Create new 'collection' record. 11. Add new item to this bib record. 12. Holdings > Item I just created > Manage bundle. 13. Add to bundle (Add MARC link = true): 1234, 0001, 0002, 0003, 0004 (barcodes of my test records). 14. Inspect MARC records: - 1234: missing 773 t - 0001: 773 t [title of my collection] - 0002: missing 773 t - 0003: 773 t [title of my collection] -> see [Additional Notes] below regarding the missing MARC tags 15. Create new test record. 16. Create new item for it with barcode = 0004. 17. Add to bundle (Add MARC link = true): 0004. 18: Inspect MARC record: - 0004: 773 t [title of my collection] # Additional Notes Test books are fake books created for testing and have a lot of data missing. Real books are, well, real books with real data. 1234: test book, created via Fast Cataloging 0001: real book, imported from Library of Congress 0002: test book, created via Fast Cataloging 0003: real book, imported from Library of Congress 0004: test book, created via New Record Note that the results, when considering these Additional Notes, show that the patch behaves as expected, except for records created via Fast Cataloging: - These records created via Fast Cataloging show up under: Holdings > Manage bundle. - But, their MARC do not contain a 773 tag. I was informed that users should never use Fast Cataloging, so I am considering this discrepancy as "irrelevant" since the feature works both on real data and properly created fake data. In conclusion, I will be signing off on this patch. Good work! # Prove Output prove ./t/db_dependent/Koha/Biblio.t ./t/db_dependent/Koha/Biblio.t .. 15/41 # Failed test 'MARC::Field->subfield(d) returns content from 264 in preference to 260' # at ./t/db_dependent/Koha/Biblio.t line 1049. # got: 'Publication 260' # expected: 'Publication 264' # Failed test 'MARC::Field->subfield(d) returns content from 264 with indicator 1 = 3 in preference to 264 without' # at ./t/db_dependent/Koha/Biblio.t line 1061. # got: 'Publication 260' # expected: 'Publication 264 Preferred' # Looks like you failed 2 tests of 24. # Failed test 'generate_marc_host_field' # at ./t/db_dependent/Koha/Biblio.t line 1099. ./t/db_dependent/Koha/Biblio.t .. 40/41 # Looks like you failed 1 test of 41. ./t/db_dependent/Koha/Biblio.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/41 subtests Test Summary Report ------------------- ./t/db_dependent/Koha/Biblio.t (Wstat: 256 (exited 1) Tests: 41 Failed: 1) Failed test: 17 Non-zero exit status: 1 Files=1, Tests=41, 18 wallclock secs ( 0.04 usr 0.01 sys + 12.20 cusr 1.91 csys = 14.16 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
