https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40866
Paul Derscheid <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187679|0 |1 is obsolete| | --- Comment #32 from Paul Derscheid <[email protected]> --- Created attachment 187688 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187688&action=edit Bug 40866: Remove original Bug 9762 implementation remnants (Part 1) This patch removes the duplicate logging code from the original Bug 9762 implementation that was not properly removed when the Alternative implementation was merged. The original implementation added separate logaction() calls in CanBookBeIssued and circulation.pl that created additional log entries with a different JSON format. This caused double logging when the Alternative implementation (which logs via AddIssue) was merged on top. Changes in this patch: C4/Circulation.pm: - Removed @message_log array and all pushes to it - Removed the separate logaction() call at the end of CanBookBeIssued - Removed 5th return value (@message_log) from CanBookBeIssued - Removed all if ($issueconfirmed) blocks that were populating @message_log circ/circulation.pl: - Removed the problematic line that added OVERRIDDEN to every confirmed checkout: $needsconfirmation->{'OVERRIDDEN'} = $issueconfirmed This addresses the double logging issue where circulation overrides were being logged twice with different formats. Signed-off-by: Andrew Fuerste Henry <[email protected]> Signed-off-by: Paul Derscheid <[email protected]> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
