https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40866
Andrew Fuerste-Henry <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187631|0 |1 is obsolete| | --- Comment #25 from Andrew Fuerste-Henry <[email protected]> --- Created attachment 187681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187681&action=edit Bug 40866: Remove original Bug 9762 implementation remnants (Part 3 - Returns) This patch removes the duplicate logging code from circ/returns.pl that was part of the original Bug 9762 implementation. The original implementation added a separate logaction() call when ignoring holds on return. This code created a custom JSON log entry with the message "return an element that is reserved". However, this logging appears to have been orphaned - there is no corresponding Alternative implementation for return override logging in the current codebase. The code was creating log entries but they were not properly integrated with any override confirmation workflow. Changes: circ/returns.pl: - Removed entire else block that created custom override log entries - Removed unused variables: $message, @message, $user, $branchcode, $barcode - Removed C4::Log qw(logaction) import as it's no longer needed This eliminates the orphaned logging code and ensures returns.pl only uses standard Koha logging mechanisms. Signed-off-by: Andrew Fuerste Henry <[email protected]> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
