https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37402
Adam Styles <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] Status|CONFIRMED |In Discussion --- Comment #2 from Adam Styles <[email protected]> --- Hi Owen and David, I built a test plan for this reported error state: Schedule report - enter no time value - operations test 1 1. login to koha instance 2. navigate to reports module 3. create a small quick test report or use an existing small test report 4. select 'schedule' from toolbar above main sql window 5. once redirected to task scheduler UI, choose 'tommorow' in drop down 'date' field. 6. enter '[email protected]' in 'email' field 7. enter no value in the 'time' field 8. press 'save'. Result - fail: - as stated in ticket the form submission created an error state producing notification 'Failed to add scheduled task' - no scheduled report action is set Schedule report - enter simple int only time value - operations test 2 1. login to koha instance 2. navigate to reports module 3. create a small quick test report or use an existing small test report 4. select 'schedule' from toolbar above main sql window 5. once redirected to task scheduler UI, choose 'tommorow' in drop down 'date' field. 6. enter '[email protected]' in 'email' field 7. enter '000' in 'time' field 8. press 'save'. Result - pass: - The form submission does not create an error state or produce a notification - report is scheduled for midnight Following on from David's suggestions, I suggest we add the following as a hotfix until a larger review of the form on this page can be done. - Add a 'required' attribute to time input field, which will natively block form submit if no value is present in this field. - Add a place holder attribute for the time input field to assist users in best time format approach - Update label string for time input field 'Time (time in 24 hours e.g 00:00' to further inform user of the format needed. e.g from.. <li><label for="starttime">Time:</label> <input type="text" name="starttime" id="starttime" value="" maxlength="5" size="5"></li> to... <li> <label for="starttime">Time (time in 24 hours e.g 00:00:</label> <input type="text" name="starttime" id="starttime" value="" maxlength="5" size="5" placeholder="hh:mm" required> </li> This would create a nice 'hot fix' for the form, to mitigate user confusion on best time format. The larger review of the task scheduler form could the be done to incorporate flat picker etc. If this works for everyone, I will assign this bug to myself and put a quick patch together for testing. Let me know. Thanks. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
