https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985
David Nind <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #60 from David Nind <[email protected]> --- Have failed QA 8-(. There are problems with the tests, everything else works as per the test plan. Failing tests - see further down for details: 1. t/db_dependent/Reserves.t: - Fails before and after the patch if "On shelf holds allowed" for the All All circulation and fine rules is set to "If any unavailable" and "If all unavailable" - I'm going to assume that this should be dealt with on another bug - The number of tests needs adjusting from 71 to 72 2. t/db_dependent/api/v1/holds.t: only passes after the patch if "On shelf holds allowed" is set to "Yes", they fail if set to the other options. The tests passed before the patch for all the options. Comment about the message in the holds column - "onShelfHoldsNotAllowed": 1. That seems a bit more "developer" focused, than for library staff. Could it be a friendlier message for staff? I realise we want to keep it succinct. 2. Examples: "Cannot place hold", "Hold not allowed", or "Not available to place a hold". 3. The message at the top of the page is: Cannot place hold - No items are available to be placed on hold. Testing notes (using KTD): 1. Set ILS-DI:AuthorizedIPs to 0.0.0.0/0 2. Step 5, after patch is applied for ILS-DI: - If "On shelf holds allowed" = "Yes", hold placed (as expected) - If "If any unavailable" and "If all unavailable", onShelfHoldsNotAllowed message returned (now working as expected) Failing tests before and after patches for t/db_dependent/Reserves.t ==================================================================== t/db_dependent/Reserves.t fails before and after the patch if "On shelf holds allowed" for the All All circulation and fine rules is set to "If any unavailable" and "If all unavailable". Note the number of tests needs adjusting from 71 to 72 after the patch is applied. prove t/db_dependent/Reserves.t t/db_dependent/Reserves.t .. 57/71 # Failed test 'Item not available for item-level hold because no effective item type' # at t/db_dependent/Reserves.t line 1486. # Looks like you failed 1 test of 3. # Failed test 'IsAvailableForItemLevelRequest() tests' # at t/db_dependent/Reserves.t line 1507. t/db_dependent/Reserves.t .. 66/71 # Looks like you failed 1 test of 71. t/db_dependent/Reserves.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/71 subtests Test Summary Report ------------------- t/db_dependent/Reserves.t (Wstat: 256 (exited 1) Tests: 71 Failed: 1) Failed test: 61 Non-zero exit status: 1 Files=1, Tests=71, 7 wallclock secs ( 0.03 usr 0.00 sys + 5.10 cusr 1.93 csys = 7.06 CPU) Result: FAIL Failing tests after patches for t/db_dependent/api/v1/holds.t ============================================================= After the patch, prove t/db_dependent/api/v1/holds.t only passes if "On shelf holds allowed" set to "Yes", if set to the other options they fail. The tests passed before the patch for all options. prove t/db_dependent/api/v1/holds.t t/db_dependent/api/v1/holds.t .. 10/20 # Failed test 'Override works for 'expired'' # at t/db_dependent/api/v1/holds.t line 859. # got: '403' # expected: '201' # Looks like you failed 1 test of 5. # Failed test ''expired' tests' # at t/db_dependent/api/v1/holds.t line 861. # Failed test 'Override works for 'debt_limit'' # at t/db_dependent/api/v1/holds.t line 888. # got: '403' # expected: '201' # Looks like you planned 7 tests but ran 5. # Looks like you failed 1 test of 5 run. # Failed test ''debt_limit' tests' # at t/db_dependent/api/v1/holds.t line 896. # Looks like you planned 7 tests but ran 2. # Looks like you failed 2 tests of 2 run. t/db_dependent/api/v1/holds.t .. 11/20 # Failed test 'add() + can_place_holds() tests' # at t/db_dependent/api/v1/holds.t line 1061. Can't call method "delete" on an undefined value at t/db_dependent/api/v1/holds.t line 890. # Looks like your test exited with 11 just after 12. t/db_dependent/api/v1/holds.t .. Dubious, test returned 11 (wstat 2816, 0xb00) Failed 9/20 subtests Test Summary Report ------------------- t/db_dependent/api/v1/holds.t (Wstat: 2816 (exited 11) Tests: 12 Failed: 1) Failed test: 11 Non-zero exit status: 11 Parse errors: Bad plan. You planned 20 tests but ran 12. Files=1, Tests=12, 9 wallclock secs ( 0.03 usr 0.01 sys + 6.98 cusr 1.41 csys = 8.43 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
