https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38136
--- Comment #46 from Julian Maurice <[email protected]> --- Created attachment 191065 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191065&action=edit Bug 38136: Refactor database translations (alternative) This has the same goals of bug 24975 but with a different approach. Bug 24975 tried the "POT/PO files as database tables" approach but it appeared that is not what best fits our needs. Instead of a "source text / translated text" mapping, we need translations to be attached to a specific "object" (or table row), which has the added benefit of keeping translations unaffected when the original string changes. It may or may not be what you want but at least this avoids the problem where fixing an error in the original string forces users to re-translate everything. We also need to be able to translate all translatable properties of a particular entity. The solution proposed here is to add a DBIC component that will add several DBIC relations to the `localization` table: * a relation named `localizations` that will return all translations for all translatable properties for all languages. * for each translatable property: * a relation named `{$property}_localizations` that will return all translations for a given property, for all languages * a relation named `{$property}_localization` that will return the translation for a given property, for the current language To enable translations for a particular entity, we will need to: * add two method calls in the "result class" corresponding to the localizable object type * in the admin interface, add a link to the the translation popup. Unlike bug 24975 there is not a page where you can translate everything. I don't know if it is really useful (probably better to translate itemtypes when you are on the itemtype page). It can be added later if needed. To give an example, this is what needs to be added manually in Koha/Schema/Result/Itemtype.pm: __PACKAGE__->load_components('+Koha::DBIx::Class::Localization'); __PACKAGE__->localization_add_relationships( 'itemtype', # the PK column 'description' # a list of translatable columns ); (see POD in Koha/Schema/Component/Localization.pm for more information) Final notes: * I wanted this patch to have as few changes as possible so I kept methods like `search_with_localization`, `children_with_localization` even if I believe they can be removed (replaced by search/children) Localizations do not need to be prefetched/joined unless you want to sort on them. For the same reason, $itemtype->unblessed now always return a `translated_description` key. This can be fixed in followup patches * There is cache involved (see Koha::Schema::Component::Localization::localization). Localizations in cache are grouped by object type and language (keys look like 'KOHA:localization:Itemtype:en') * By keeping a single table for all translations of all entities, we cannot have data integrity at the RDBMS level, but automatic deletion of translations is handled by the DBIC `cascade_delete` feature, so integrity should be fine as long as no raw SQL update/delete operation is involved. Signed-off-by: Caroline Cyr La Rose <[email protected]> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
