https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25090
Katrin Fischer <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #53 from Katrin Fischer <[email protected]> --- 1) QA checks (blocker) I didn't manage to make the tests pass. Had run updatedatabase and started out with a fresh ktd sample data database. Processing additional checks PASS! * Have you considered sharing the new syspref to HEA? (see bug 23849 and C4/UsageStats.pm) Running tests (1) * Proving /kohadevbox/koha/t/db_dependent/Koha/Patron/Modifications.t FAIL # Failed test 'no warnings' # at /usr/share/perl/5.36/Test/Builder.pm line 193. # There were 1 warning(s) # Previous test 0 '' # DBIx::Class::Storage::DBI::insert(): Missing value for primary key column 'borrowernumber' on BorrowerModification - perhaps you forgot to set its 'is_auto_increment' attribute during add_columns()? Treating 'borrowernumber' implicitly as an autoinc, and attempting value retrieval at /kohadevbox/koha/Koha/Object.pm line 174 # at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 2110. # DBIx::Class::Storage::DBI::insert(DBIx::Class::Storage::DBI::mysql=HASH(0x618a91ac15e0), DBIx::Class::ResultSource::Table=HASH(0x618a91bb0500), HASH(0x618a922e0ef0)) called at /usr/share/perl5/DBIx/Class/Row.pm line 407 # DBIx::Class::Row::insert(Koha::Schema::Result::BorrowerModification=HASH(0x618a922c7298)) called at /usr/share/perl5/DBIx/Class/Row.pm line 1345 # DBIx::Class::Row::update_or_insert(Koha::Schema::Result::BorrowerModification=HASH(0x618a922c7298)) called at /kohadevbox/koha/Koha/Object.pm line 174 # Koha::Object::try {...} () called at /usr/share/perl5/Try/Tiny.pm line 100 # eval {...} called at /usr/share/perl5/Try/Tiny.pm line 93 # Try::Tiny::try(CODE(0x618a921c8cb8), Try::Tiny::Catch=REF(0x618a922d13f8)) called at /kohadevbox/koha/Koha/Object.pm line 225 # Koha::Object::store(Koha::Patron::Modification=HASH(0x618a92209130)) called at /kohadevbox/koha/Koha/Patron/Modification.pm line 66 # Koha::Patron::Modification::store(Koha::Patron::Modification=HASH(0x618a92209130)) called at /kohadevbox/koha/t/db_dependent/Koha/Patron/Modifications.t line 533 # main::__ANON__() called at /usr/share/perl/5.36/Test/Builder.pm line 374 # eval {...} called at /usr/share/perl/5.36/Test/Builder.pm line 374 # Test::Builder::subtest(Test::Builder=HASH(0x618a87619f68), "notify_library_of_registration() tests", CODE(0x618a874458f0)) called at /usr/share/perl/5.36/Test/More.pm line 809 # Test::More::subtest("notify_library_of_registration() tests", CODE(0x618a874458f0)) called at /kohadevbox/koha/t/db_dependent/Koha/Patron/Modifications.t line 547 # # Looks like you planned 8 tests but ran 9. # Looks like you failed 1 test of 9 run. /kohadevbox/koha/t/db_dependent/Koha/Patron/Modifications.t .. Dubious, test returned 1 (wstat 256, 0x100) All 8 subtests passed 2) Code Review a) Atomic updates could be merged into one file. 3) Testing a) Configuration I hope I got everything right: With this patch we have 2 ways to trigger the move from the borrower_modifications table to create a patron account for an OPAC self registration: * Patron verifyting their email address * Staff verifying the account Important: you can only have one or the other. The involved system preferences are: * PatronSelfRegistrationVerifyByEmail * EmailPatronRegistrations To the user the setup could be a little confusing, as the setup will also determine which emails are sent. We got: * PatronSelfRegistrationVerifyByEmail = Are not required to be notified EmailPatronRegistrations = no email --> No notification * PatronSelfRegistrationVerifyByEmail = Are not required to be notified EmailPatronRegistrations != none --> OPAC_REG to the library * PatronSelfRegistrationVerifyByEmail = must be verified by library staff EmailPatronRegistrations != none --> OPAC_REG_VERIFY_LIB to the library * PatronSelfRegistrationVerifyByEmail = must be verified by the patron EmailPatronRegistrations != none --> OPAC_REG_VERIFY to the patron --> OPAC_REG to library I feel like it's not super clear from the preference descriptions yet, but lack a good idea. Maybe we could add another hint to make it a little clearer. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
