https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24679
--- Comment #15 from Katrin Fischer <[email protected]> --- The only real problem is the failing QA checks for tidiness. So I will sign-off and fail QA for that after. Please reset back to sign-off if it's only the formatting changes :) 1) QA checks: Patches require tidying (blocker) testing 3 commit(s) (applied to 84227f7 'db8 Bug 41682: DBRev 25.12.00.014') Processing files [RUNNING] C4/MarcModificationTemplates.pm [RUNNING] C4/Record.pm [RUNNING] Koha/Exporter/Record.pm [RUNNING] koha-tmpl/intranet-tmpl/prog/en/modules/tools/export.tt [RUNNING] t/db_dependent/Exporter/Record.t [RUNNING] tools/export.pl [FAIL] C4/MarcModificationTemplates.pm [PASS] t/db_dependent/Exporter/Record.t [PASS] koha-tmpl/intranet-tmpl/prog/en/modules/tools/export.tt [FAIL] C4/Record.pm [FAIL] Koha/Exporter/Record.pm [FAIL] tools/export.pl Result: [FAIL] C4/MarcModificationTemplates.pm FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl C4/MarcModificationTemplates.pm` [FAIL] C4/Record.pm FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl C4/Record.pm` [FAIL] Koha/Exporter/Record.pm FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl Koha/Exporter/Record.pm` [PASS] koha-tmpl/intranet-tmpl/prog/en/modules/tools/export.tt [PASS] t/db_dependent/Exporter/Record.t [FAIL] tools/export.pl FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl tools/export.pl` Processing additional checks * Signed-off-by email 'Signed-off-by: Devinim <[email protected]>' seems invalid * Was this bug sponsored by anyone? Running tests (1) * Proving /kohadevbox/koha/t/db_dependent/Exporter/Record.t PASS 2) Code review (OK) a) CSV? This updates marc2csv etc. but the test plan includes no info about exporting a CSV format. As the option only appears after a CSV profile is added, I feel it should be inlcuded: - Add a CSV profile of type "Export records" - For example: Title=245|Test=999 - Export records using the CSV profile, verify MARC template is applied correctly 3) Testing Tested with authority and bibliographic records, .mrc, .xml and .csv. It worked well! -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
