https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32419

Katrin Fischer <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #8 from Katrin Fischer <[email protected]> ---
1) QA checks - passing
2) Code review 

a) Maintenance (to be discussed)

This adds separate file for the result list of Lists, where it was before using
the standard result list XSLT. The result list displays the item availabiltiy
as well. I am not sure yet why the change is required, can you explain?

I believe we should try and avoid copying the XSLT code in full. Maybe a more
clever solution could be found using includes or similar? We are quite bad at
maintaining display code in multiple places.

b) UNIMARC (blocker)

Also: it's missing the equivalent file for UNIMARC. This will break UNIMARC:

-            # Lists default to *Results.xslt
             $htdocs  = C4::Context->config('intrahtdocs');
             $theme   = C4::Context->preference("template");
-            $xslfile = C4::Context->preference('marcflavour') .
"slim2intranetResults.xsl";
+            $xslfile = C4::Context->preference('marcflavour') .
"slim2intranetLists.xsl";

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to