https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32419
--- Comment #9 from Aleisha Amohia <[email protected]> --- (In reply to Katrin Fischer from comment #8) > 1) QA checks - passing > 2) Code review > > a) Maintenance (to be discussed) > > This adds separate file for the result list of Lists, where it was before > using the standard result list XSLT. The result list displays the item > availabiltiy as well. I am not sure yet why the change is required, can you > explain? The code for item availability in the staff interface's search results sits outside of the XSLT. Instead it is populated programmatically inside koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt . That's why I couldn't simply add availability info to the current results XSLT as we'd end up with duplicate information on the screen. > > I believe we should try and avoid copying the XSLT code in full. Maybe a > more clever solution could be found using includes or similar? We are quite > bad at maintaining display code in multiple places. It's true it would be nice for some of these sections to live as includes within MARC21slimUtils.xsl and do a full refactor down the line, but this bug report is about making a staff interface display match an equivalent OPAC display, so that refactoring would be out of scope for this particular enhancement. > > b) UNIMARC (blocker) > > Also: it's missing the equivalent file for UNIMARC. This will break UNIMARC: > > - # Lists default to *Results.xslt > $htdocs = C4::Context->config('intrahtdocs'); > $theme = C4::Context->preference("template"); > - $xslfile = C4::Context->preference('marcflavour') . > "slim2intranetResults.xsl"; > + $xslfile = C4::Context->preference('marcflavour') . > "slim2intranetLists.xsl"; I'll need to talk to the sponsoring library about this. Aleisha -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
