https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41813
Lari Taskula <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192964|0 |1 is obsolete| | --- Comment #2 from Lari Taskula <[email protected]> --- Created attachment 192965 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192965&action=edit Bug 41813: Use library's From-address for ILL staff notifications When sending ILL staff notifications, the email "To" and "From" addresses are set equal. Libraries' sending address may differ from receiving address, so this feature should be using the usual From-address that Koha uses in any other types of email notifications. This patch changes ILL staff notifications to use the usual From address. Before applying this patch, to reproduce: 1. Create the following SQL report SELECT * FROM message_queue ORDER BY message_id DESC; 2. Enable ILL requests using system preference ILLModule 3. Navigate to Administration > Libraries 4. Make sure "ILL staff email" is empty 5. Make sure "Email" is empty 6. Set system preference ILLDefaultStaffEmail to [email protected] 7. Set system preference KohaAdminEmailAddress to [email protected] 8. Set system preference ILLSendStaffNotices to ILL_REQUEST_CANCEL|ILL_REQUEST_MODIFIED|ILL_PICKUP_READY|ILL_PARTNER_REQ|ILL_REQUEST_UNAVAIL|ILL_REQUEST_UPDATE|ILL_REQ_CREATED 9. Navigate to OPAC 10. Create a new ILL request from OPAC 11. Run your SQL report from step 1 12. Observe first row column from_address as [email protected] It should be [email protected] instead Apply this patch To test: 1. Unless you already didn't, create the following SQL report SELECT * FROM message_queue ORDER BY message_id DESC; 2. Enable ILL requests using system preference ILLModule 3. Navigate to Administration > Libraries 4. Make sure "ILL staff email" is empty 5. Make sure "Email" is empty 6. Set system preference ILLDefaultStaffEmail to [email protected] 7. Set system preference KohaAdminEmailAddress to [email protected] 8. Set system preference ILLSendStaffNotices to ILL_REQUEST_CANCEL|ILL_REQUEST_MODIFIED|ILL_PICKUP_READY|ILL_PARTNER_REQ|ILL_REQUEST_UNAVAIL|ILL_REQUEST_UPDATE|ILL_REQ_CREATED 9. Navigate to OPAC 10. Create a new ILL request from OPAC 11. Run your SQL report from step 1 12. Observe first row column from_address as [email protected] -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
