https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41310
David Cook <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #15 from David Cook <[email protected]> --- (In reply to David Cook from comment #14) > The test plan is missing the steps for upgrading the database and restarting > services but that's ok. Not a blocker. > > I don't know about having "ActionLogsEnableIPLogging" under "Debugging" > instead of "Logging", but... I'm not too fussed. If we want to change the > description and categorisation later, it's not hard to do, so I think it's > fine. > > I can't recall if we're supposed to include Koha/Schema/Result/ActionLog.pm > in the main patch. I think it's supposed to be in a separate patch, but I'm > double-checking with QA team on that one. > > Other than that... I think it's all good. It works as described. I'll mark > as Signed Off for now. Actually, I was a bit premature there. Checked with the QA team and Koha/Schema/Result/ActionLog.pm should be in a separate patch as the RM will ignore that patch later and generate the schema files later. (It's just included for testing purposes.) The QA tools show a few other problems: Result: [PASS] C4/Log.pm [SKIP] Koha/Schema/Result/ActionLog.pm SKIP pod_coverage No POD exists [FAIL] installer/data/mysql/atomicupdate/bug_41310-add_ip_address_to_action_logs.pl FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl installer/data/mysql/atomicupdate/bug_41310-add_ip_address_to_action_logs.pl` [PASS] installer/data/mysql/kohastructure.sql [PASS] installer/data/mysql/mandatory/sysprefs.sql [PASS] koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/logs.pref [FAIL] t/db_dependent/TestIpLogging.t FAIL file_permissions File must have the exec flag FAIL test_no_warnings 'use Test::NoWarnings' must be present in this test file. Processing additional checks PASS! * Was this bug sponsored by anyone? * Have you considered sharing the new syspref to HEA? (see bug 23849 and C4/UsageStats.pm) Running tests (1) * Proving /kohadevbox/koha/t/db_dependent/TestIpLogging.t PASS -- So I should be able to signoff once you move Koha/Schema/Result/ActionLog.pm to a separate patch, and address those FAILs in the QA test results. They should be pretty easy to do. Let me know if you need help with any of those. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
