https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41310

--- Comment #17 from Saiful Amin <[email protected]> ---
(In reply to David Cook from comment #14)
> The test plan is missing the steps for upgrading the database and restarting
> services but that's ok. Not a blocker.

Sorry I missed that! I'll add now.

> I don't know about having "ActionLogsEnableIPLogging" under "Debugging"
> instead of "Logging", 

I did consider placing it under "Logging", but it seemed the odd one out.
Whereas, placing it next to 'ActionLogsTraceDepth' felt more logical.

> So I should be able to signoff once you move Koha/Schema/Result/ActionLog.pm 
> to a separate patch, and address those FAILs in the QA test results. They
> should be pretty easy to do. Let me know if you need help with any of those.

I'll need help with this. Is it two separate commits in same patch or a
follow-up patch?

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to