https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41383
Saiful Amin <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190311|0 |1 is obsolete| | --- Comment #2 from Saiful Amin <[email protected]> --- Created attachment 194439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194439&action=edit Bug 41383 - SIP2 server does not search patrons by unique patron attributes (alternate IDs unusable in SIP2) Currently, Koha::Patrons->find_by_identifier only searches for patrons by userid and cardnumber. This patch extends this method to also search by unique borrower attributes (where unique_id=1). This enhancement allows modules like SIP2 to identify patrons using alternative unique identifiers defined in the system. Test Plan: 1. Test current behaviour: - Go to Administration -> Patron attribute types - Create a new Patron attribute with: - Patron attribute type code = "AltID" - Description = "Alternate ID" - Unique identifier checkbox selected - Save - Edit any patron record and go to Additional attributes and identifiers - Add a value "altid123" to "Alternate ID" - Save - Use any SIP2 client to search for the patron using this attribute value. e.g., `perl misc/sip_cli_emulator.pl -su term1 -sp term1 -l CPL --host localhost --patron altid123 -m patron_information` - Verify that the patron is NOT found with this message: 'AFInvalid cardnumber' e.g.: READ: 64YYYY 00120260304 104611000000000000000000000000AOCPL|AAaltid123|AE|BLN|AFInvalid cardnumber| 2. Apply the patch. 3. Run the tests: prove t/db_dependent/Koha/Patrons.t - Verify that all tests pass, including the new cases for unique attribute lookup. 4. Test with patch applied: - Use any SIP2 client to search for the patron using this attribute value. e.g., `perl misc/sip_cli_emulator.pl -su term1 -sp term1 -l CPL --host localhost --patron altid123 -m patron_information` - Verify that the patron is found with this message: 'AFGreetings from Koha.' e.g.: READ: 64 00120260304 104328000000000000000000000000AOCPL|AA23529001000463|AEEdna Acosta|BLY|BHUSD|BV0|CC5|BD7896 Library Rd. Portland, OR 44240|BF(212) 555-1212|PB19800424|PCPT|PIY|AFGreetings from Koha. | 5. Test non-unique attribute: - Go to Administration -> Patron attribute types - Edit "Alternate ID" attribute type - Unique identifier checkbox NOT selected - Save - Use any SIP2 client to search for the patron using this attribute value. e.g., `perl misc/sip_cli_emulator.pl -su term1 -sp term1 -l CPL --host localhost --patron altid123 -m patron_information` - Verify that the patron is NOT found with this message: 'AFInvalid cardnumber' e.g.: READ: 64YYYY 00120260304 104611000000000000000000000000AOCPL|AAaltid123|AE|BLN|AFInvalid cardnumber| 6. Sign-off -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
