https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41834
--- Comment #5 from David Cook <[email protected]> --- Comment on attachment 194409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194409 Bug 41834: Set systempreferences's options, explanation and type to NULL Review of attachment 194409: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=41834&attachment=194409) ----------------------------------------------------------------- Unfortunately, I've run out of time today, but I'll take another look at this one next week, as I'm pretty excited about it. ::: C4/Installer.pm @@ +460,5 @@ > # marc_cleaned finds the marcflavour, without the variant. > my $marc_cleaned = 'MARC21'; > $marc_cleaned = 'UNIMARC' if $marcflavour =~ /unimarc/i; > + my $request = $self->{'dbh'} > + ->prepare("INSERT IGNORE INTO `systempreferences` (variable, value) > VALUES('marcflavour', '$marc_cleaned')"); At some point, someone should make this use a prepared statement, but all good for now. ::: installer/data/mysql/atomicupdate/bug_41834.pl @@ +8,5 @@ > + up => sub { > + my ($args) = @_; > + my ( $dbh, $out ) = @$args{qw(dbh out)}; > + > + # First fix some discrepancies Hmm I don't know that we should be fixing discrepancies here? @@ +36,5 @@ > + DELETE FROM systempreferences WHERE variable='OPACMySummaryNote' > + } > + ); > + > + # Then remove NULL the 3 columns for sysprefs listed in sysprefs.sql Hmm that's an interesting point. I suppose local sysprefs will still need to retain this data in the database... and there's no clear separation of local and built-in sysprefs... ::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref @@ +696,3 @@ > multiple: > intransit: In-transit > checkedout: Checked out Are all the circulation.pref changes just tidy-ups unrelated to the overall bug here? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
