https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42764
--- Comment #11 from Martin Renvoize (ashimema) <[email protected]> --- Created attachment 199896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199896&action=edit Bug 42764: Fix false positives caused by mixed filetypes in CI failure store The ci-results repo stores all failures from a single test run as one flat JSON array, regardless of whether they came from the pl, tt, or js filetype pass. On the next incremental run, get_files_to_test('pl') reads that entire list -- including any .tt failures -- and calls remove_exceptions with the 'pl' context. Since .tt files only appear in the tt exception list, they survive the filter and get codespell'd in the pl pass where nothing is configured to exclude them. The fix filters stored failures by filetype before applying exceptions, so each pass only re-checks failures that belong to its own type. Test plan: 1. Apply all patches 2. Add a file to the tt codespell exceptions in Koha::Devel::Files that contains a word codespell would flag 3. Introduce a deliberate failure in another file so the ci-results repo records the excepted .tt file as a previous failure 4. On the next incremental run, confirm the excepted .tt file is not re-tested in the pl or js pass 5. prove xt/author/codespell.t => Tests pass; no false positives from cross-filetype re-checks -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
