https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42764
--- Comment #13 from Martin Renvoize (ashimema) <[email protected]> --- (In reply to Jonathan Druart from comment #9) > Comment on attachment 199892 [details] [review] > Bug 42764: Fix false positives caused by mixed filetypes in CI failure store > > Review of attachment 199892 [details] [review]: > ----------------------------------------------------------------- > > ::: Koha/Devel/CI/IncrementalRuns.pm > @@ +140,4 @@ > > @koha_commit_history; > > if ($last_build_commit) { > > @files = @{ from_json( > > read_file("$self->{git_repo_dir}/$self->{test_dir}/$last_build_commit") ) }; > > + @files = grep { ( eval { $dev_files->get_filetype($_) } // > > '' ) eq $filetype } @files; > > Why not simply `@files = grep { $dev_files->get_filetype($_) eq $filetype } > @files;`? Fixed inline.. I was accounting for the die, but on retrospect we want a loud die if a filetype isn't recognised. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
