https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16631
Pedro Amorim (ammopt) <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #166 from Pedro Amorim (ammopt) <[email protected]> --- Blockers: 1) This patch is removing the 'templates' template param in guided_reports.pl that was passed to reports-toolbar.inc. It is (unintentionally?) removing the 'Run with template' functionality, and this becomes dead code in reports-toolbar.inc: [% IF templates.count %] 2) Reports.t contains syntax errors: syntax error at /kohadevbox/koha/t/db_dependent/Koha/Reports.t line 290, near "subtest " Execution of /kohadevbox/koha/t/db_dependent/Koha/Reports.t aborted due to compilation errors. 3) The following path in guided_reports.pl is meant to expect the 'template_code' param (introduced in bug 38621): if ( $format eq 'template' ) But this patch is reverting that back to expect the 'template' param. reports-toolbar.inc sends format=template&template_code=<code> so the 'template' param there will be empty. This is almost certainly breaking the functionality introduced by 38621. Please double-check. Non-blockers: 1) Double-check that the author is as intended: "Cameron E. Tidd" <[email protected]> 2) The functional changes are all in a single large commit. Splitting by concern (model changes, CGI changes, template changes, tests) would make review easier and history more useful. 3) The test plan is overly long. Sometimes less is more and that applies here, in my opinion. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
