https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42915
--- Comment #26 from Martin Renvoize (ashimema) <[email protected]> --- Created attachment 201920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201920&action=edit Bug 42915: (QA follow-up) Declare all_libraries once, unconditionally, in request.tt holds_table.inc is INCLUDEd in a loop from reserve/request.tt whenever HoldsSplitQueue splits the holds queue by branch/itemtype, or when holds for more than one biblio are shown at once (multi_hold). Each inclusion appended its own <script> block declaring `all_libraries`, and since top-level `let`/`const` in separate inline <script> tags share the page's global lexical scope, the second and subsequent occurrences threw "Identifier 'all_libraries' has already been declared", breaking those script blocks and the pickup-library filtering that depends on `all_libraries` being set. Worse, that script block is only emitted when a biblio's holds are actually rendered (biblioloo.total_holds > 0), but holds.js is loaded unconditionally by reserve/request.tt and reads `all_libraries` at top-level parse time. Placing the very first hold on a title (0 existing holds) therefore threw: ReferenceError: all_libraries is not defined breaking every hold-management handler defined below that line in holds.js. Fix both by declaring `all_libraries` exactly once, unconditionally, in request.tt's existing page-global script block (alongside the other unconditional globals such as HidePatronName and HoldsSplitQueue), before Asset.js("js/holds.js") loads, instead of duplicating it inside the per-title/per-split holds_table.inc include. To test: 1. Search for a title with no existing holds and start placing one 2. Without this patch: browser console shows "ReferenceError: all_libraries is not defined" as soon as the page loads 3. With this patch: no console errors 4. Set HoldsSplitQueue to "pickup library", place holds on a title for two different pickup libraries, confirm both split tables render with working patron-name and pickup-library filtering and no console errors 5. Confirm the patron's own Holds tab (moremember.pl/circulation.pl) still loads without console errors -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
