https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42915
--- Comment #27 from Martin Renvoize (ashimema) <[email protected]> --- Created attachment 201921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201921&action=edit Bug 42915: (QA follow-up) Restore fallback message for holds with no patron data The "Add patron names to data in column def in holds table" patch dropped the null-patron handling in the patron column's render function, so a hold row whose patron embed comes back null (e.g. a user without permission to view the patron on that hold, per Bug 23269's test plan) now renders a blank cell instead of a useful message. Restore the fallback, sourced from `all_libraries` (populated by this same table's include) rather than the separate `libraries` global, and check `row.patron` directly instead of the now-composite `data` column key. To test: 1. Have holds on a bib from patrons the logged in user cannot see (e.g. IndependentBranches, or a reduced permission set) 2. View the record's Holds tab 3. Confirm rows with no visible patron show "A patron from library <library>" instead of a blank Patron cell Signed-off-by: Martin Renvoize <[email protected]> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
