https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43546
--- Comment #28 from Martin Renvoize (ashimema) <[email protected]> --- Two RM follow-ups were pushed with this bug (attachments 208568 and 208569; commits 103c68db4de and 26474a2689e). They are attached for the record and are already on main. 1. debian/control: Add libgetopt-long-descriptive-perl Koha::Script now loads Getopt::Long::Descriptive at compile time, and 120 scripts use Koha::Script, so the module is a hard runtime dependency. It was in the cpanfile but not in debian/control, so a Debian package built from main would not have pulled in libgetopt-long-descriptive-perl and every script using Koha::Script would have failed to compile. The package is now listed in both the Build-Depends and the Depends lists, unversioned like the other generated entries. debian/control is normally regenerated from control.in by debian/update-control, which maps the whole cpanfile using apt-file on the build machine; it was edited directly (as Bug 42860 did) to avoid unrelated churn. 2. cpanfile: Lower the Getopt::Long::Descriptive minimum to 0.109 The cpanfile asked for 0.116. That is simply the version installed in KTD (Debian trixie), not something Koha needs. The packaged versions are 0.109 in Ubuntu 22.04, 0.111 in Debian bookworm and Ubuntu 24.04, and 0.116 in Debian trixie, so a 0.116 minimum would be reported as too old on the first three even with the distribution package installed. Before lowering it I checked the changelog and our usage. The features Koha::Script relies on (required, default, implies, callbacks, shortcircuit, prog_name, Usage->text and Usage->die) all predate 0.109; shortcircuit is the newest, from 0.095. None of the changes in 0.110 to 0.117 affects them: 0.112 drops the redundant option warning, 0.113 reflows usage output, 0.114 stops treating (required => 0) as required (not used here), 0.115 handles a missing format string (always passed), 0.116 restores the Getopt::Long configuration after parsing, 0.117 adds experimental completion script generation. t/Koha/Script.t and the converted cart_to_shelf.pl and runreport.pl give identical results with 0.116, with 0.111 on Getopt::Long 2.54 and with 0.109 on Getopt::Long 2.52 (the pairs shipped by Debian bookworm and Ubuntu 22.04). 0.105 (Debian bullseye) was not tested. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
