https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391
--- Comment #301 from Katrin Fischer <[email protected]> --- Created attachment 210589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=210589&action=edit Bug 31391: Fix userid in reserve/modrequest.pl checkauth returns ( $userid, $cookie, $sessionID, $flags ). Assigning it to a scalar keeps the last element, so $userid held the flags hashref and haspermission always returned false for cud-convertall. Converting holds to recalls did nothing, even for superlibrarians. Test plan: 1) Enable recalls: set 'UseRecalls' to 'can be placed through the staff interface only': http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=UseRecalls 2) Go to http://localhost:8081/cgi-bin/koha/admin/smart-rules.pl and under the default rule set: - 'Recalls allowed (total)': 5 - 'Recalls per record': 3 - 'On shelf recalls allowed': if any unavailable - 'Recall due date interval': 5 - 'Recall overdue fine amount': 5 - 'Recall pickup period': 2 3) Check out item 39999000003154 to patron with cardnumber 23529000120056 4) Place a hold on record 76 for patron with cardnumber 23529000651225: http://localhost:8081/cgi-bin/koha/reserve/request.pl?biblionumber=76 5) Before applying the patch, on the same page tick the checkbox next to the hold, click 'Convert selected to recall' and confirm in the modal 6) Confirm nothing happens: the hold is still there and no recall was created: http://localhost:8081/cgi-bin/koha/recalls/recalls_queue.pl 7) Apply the patch, repeat step 5 8) Confirm the hold is gone and a recall now exists for patron 23529000651225 on record 76 Co-Authored-By: Claude Opus 5.5 <[email protected]> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
