https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43805
--- Comment #15 from Andrew Fuerste-Henry <[email protected]> --- Created attachment 211116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=211116&action=edit Bug 43805: (QA follow-up) Cover the vendors and the item lists Logging back in after a session timeout took the user to a blank page on the vendors, and to a 404 error on the item lists. * The vendors page, /cgi-bin/koha/acquisition/vendors, is served by acqui/vendors.pl, not by a script that has its path. After logging in, the user is on /cgi-bin/koha/acqui/vendors.pl/1, which the router does not know, so nothing was shown. removeScriptExtension, that only took the extension of the script out, can now be given the path of the script and the one of the page, and the vendors give theirs. * The item lists, /cgi-bin/koha/lists/items, are served through the same kind of rewrite rule as the record sources, and had the same 404 error: the rule rewrote the request for the script itself into items.pl.pl. The rule now leaves it alone, as the ones of the record sources and of the circulation triggers do (in etc/koha-httpd.conf and the Debian template), and the item lists take the extension out of the address like the other pages. The tests of the login now also cover the vendors and the item lists. To test: 1. Apply the patches 2. Start a new KTD (kd up / ktd up), as the rewrite rules are generated when it starts, then yarn js:build and restart_all 3. Open /cgi-bin/koha/acquisition/vendors/add, log out in another tab, reload and log in => You land on the add vendor form, at the URL without acqui and .pl 4. Open /cgi-bin/koha/lists/items/add, log out in another tab, reload and log in => You land on the add item list form 5. Open /cgi-bin/koha/lists/items.pl and /cgi-bin/koha/acqui/vendors.pl => The pages load, at /cgi-bin/koha/lists/items and /cgi-bin/koha/acquisition/vendors 6. Run $ ktd --shell k$ yarn cypress run --spec t/cypress/integration/Admin/VuePagesLogin_spec.ts => SUCCESS: Tests pass! 7. Without the patch, the tests of the vendors and of the item lists fail 8. Sign off :-D Co-Authored-By: Claude Sonnet 5.5 <[email protected]> Signed-off-by: Andrew Fuerste Henry <[email protected]> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
