https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43805
Martin Renvoize (ashimema) <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #12 from Martin Renvoize (ashimema) <[email protected]> --- Thanks Andrew, both are fixed in the new (QA follow-up) patch, on top of David's two signed patches, which are unchanged. The vendors: they are not served by a script that has the path of their page. The page is /cgi-bin/koha/acquisition/vendors, served by acqui/vendors.pl, so after logging in the user was on /cgi-bin/koha/acqui/vendors.pl/1, which the Vue router does not know, hence the blank page. Taking the extension out of the address, as was done for the record sources and the circulation triggers, is not enough for them. removeScriptExtension can now be given the path of the script and the one of the page, and the vendors give theirs, so the address goes back to /cgi-bin/koha/acquisition/vendors/1. The rewrite rule of the vendors needs no change, as the path of its script is not the one of the page. The item lists: they are served through the same kind of rewrite rule as the record sources, and had the same 404 error, as the rule rewrote the request for lists/items.pl into lists/items.pl.pl. The rule now leaves the script alone, like the ones of the record sources and of the circulation triggers (in etc/koha-httpd.conf and in the Debian template), and the item lists take the extension out of the address like the other pages. Cypress/VuePagesLogin_spec.ts now also covers the vendors and the item lists. Without the new patch their tests fail, with the 404 error for the item lists and a page that is not shown for the vendors. With it all 12 tests pass. Note that for the vendors the test uses /add, not /vendors/1: it goes through the same code, but it does not need a vendor to exist. As before, the rewrite rules are generated when KTD starts, so it needs a new KTD (kd up / ktd up), then yarn js:build and restart_all. I also ran the other Cypress tests of these pages: Acquisitions/Vendors_spec.ts, Breadcrumbs_spec.ts, Toolbar_spec.ts and VueFramework_spec.ts pass. In ItemLists_spec.ts, "Item List shares CRUD operations should add a share" fails, but not because of this bug: it fails the same way on main (commit eda13b6610d) with the changes of this bug to Koha::AuthUtils and to the item lists page taken out. Cypress says the search field of the patron selector is covered by the library badge (<span class="badge ac-library">A Library</span>). That looks related to the new PatronSelect component of bug 43518, but I did not check that. It needs its own look. koha-qa is clean. Setting back for testing. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
